Review Board 1.5.4

Issue 177: n.l.http.XmlResponse should take a code: Int

Updated 2 years, 2 months ago

Alex Boisvert Reviewers
177 dchenbecker, dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive
Issue 177: n.l.http.XmlResponse should take a code: Int
http://github.com/dpp/liftweb/issues/closed/#issue/177

I reworked the patch:

-no more clumsy XmlCodeResponse case class

-added overloaded constructors on the companion object to support XmlResponse(xml, code, mime) with optional 'code' and 'mime' parameters.
Locally on test app
Ship it!
Posted 2 years, 2 months ago (November 12th, 2009, 2:45 p.m.)
Looks good
Review request changed
Updated 2 years, 2 months ago (November 12th, 2009, 3:28 p.m.)
  • Issue 177: n.l.http.XmlResponse should take a code: Int
    http://github.com/dpp/liftweb/issues/closed/#issue/177
    
    Added new XmlCodeResponse case class (similar in spirit to XmlMimeResponse)

    Issue 177: n.l.http.XmlResponse should take a code: Int
    http://github.com/dpp/liftweb/issues/closed/#issue/177
    
    I reworked the patch:
    
    -no more clumsy XmlCodeResponse case class
    
    -added overloaded constructors on the companion object to support XmlResponse(xml, code, mime) with optional 'code' and 'mime' parameters.
Posted 2 years, 2 months ago (November 12th, 2009, 5:47 p.m.)
It is helpful if cookies is also customizable, as I reported at
  http://groups.google.com/group/liftweb/browse_thread/thread/ea6702c176519929?tvc=2
  1. Ok, I'll add variations with cookies.
Ship it!
Posted 2 years, 2 months ago (November 13th, 2009, 11:53 a.m.)
Good additions.