Review Board 1.5.4

Add proper support to SQL Server driver for Unicode text, and make the driver version-aware for data types

Updated 2 years, 2 months ago

Derek Chen-Becker Reviewers
16 dchenbecker, dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive 
Split SQL Server support into a pre-2005 and 2005-and-up driver to support the changed data types.
None yet. I don't have SQL Server. I'll ask for guinea pigs on the list.
Tim Perrett
Posted 2 years, 3 months ago (October 26th, 2009, 4:12 p.m.)
Derek, what type of column should I be testing this with in Mapper? It appears that you've only updated the clob cols to use ntext... will normal MappedString still use varchar? shouldn't they use nvarchar also? 
  1. You're right, I forgot to update MappedString. I'll get that fixed tomorrow. Thanks!
  2. OK, checked in the change. I screwed up Git locally, so please delete your wip-dcb-issue-16-sql-server branch and pull it again from GitHub.
  3. Tim, when you have time could you test this again before I merge it?
Review request changed
Updated 2 years, 3 months ago (October 27th, 2009, 1:13 p.m.)
Fixed missing MappedString support.
Ship it!
Tim Perrett
Posted 2 years, 2 months ago (November 13th, 2009, 4:11 p.m.)
Just tested this against SQL Server 2005 - looks good to me. Its not using the unicode text cols; sweet.