Review Board 1.5.4

Issue #69 - GC code should not be added to pages that contains no bound functions

Updated 2 years, 3 months ago

Marius Danciu Reviewers
marius-wip-issue-69
69 dchenbecker, dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive 
This are the changes pertaining to http://github.com/dpp/liftweb/issues#issue/69

Br's,
Marius
None
Review request changed
Updated 2 years, 3 months ago (October 18th, 2009, 11:43 a.m.)
    • added 69
David Pollak
Posted 2 years, 3 months ago (October 18th, 2009, 9:13 p.m.)
There are too many changes to how page timeouts are done.  Speicifically:

      val ret =  Helpers.nextFuncName

		

213 	

      S.addFunctionMap(ret, S.SFuncHolder(ignore => {}))

		

214 	

      ret

Do not ship it.
  1. Yes I was wondering about that ... and I was counting on your comment on this.

So why do we keep that function? Could you please clarify?

If we keep it we'll always have at least one function bound to a specific owner hence even for clean pages where user bound no function.

Br's,
Marius
Ship it!
David Pollak
Posted 2 years, 3 months ago (October 19th, 2009, 10:40 a.m.)
After a chat with Marius, we need to keep these changes.
Review request changed
Updated 2 years, 3 months ago (October 22nd, 2009, 10:23 a.m.)
Due to testes performed some code changes were needed ... also fetching latest code from Dave's monster commit :)

Please see the diff