Review Board 1.5.4

Issue 626

Updated 1 year, 3 months ago

Mads Hartmann Reviewers
Mads_TableSorter_Enhancements_626
dchenbecker, dpp, timperrett, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
Issue 626: https://www.assembla.com/spaces/liftweb/tickets/626-tablesorter-enhancements

I've used default arguments to avoid any breaking changes. 
mvn clean install ofc. 

Also expanded the demo to contain 2 new tables. The first is configured using the new TableSorter.option method and the last one uses the jsRender method which I improved as well.
Derek Chen-Becker
Posted 1 year, 5 months ago (September 7th, 2010, 7:12 a.m.)
I see the value of default args here, but doesn't this need to be Scala 2.7.7 compatible still?
  1. Are we not allowed to add 2.8.0 only features? If that's the case I would have to use overloaded method instead of default args (sad panda) - Won't take that long though so it's not a big deal :)
Review request changed
Updated 1 year, 4 months ago (September 21st, 2010, 4:16 a.m.)
 Used overloaded methods instead of default arguments to keep scala 2.7.7 compatability
Ship it!
Derek Chen-Becker
Posted 1 year, 4 months ago (September 21st, 2010, 8:49 a.m.)
Looks great! Looking forward to seeing it in 2.2