Review Board 1.5.4

[1/3] issue594 & issue617 - make Record Screen compatible by rearranging types of some methods, tweaking validation, and so on to conform to util.BaseField

Updated 1 year, 5 months ago

Ross Mellgren Reviewers
rmm_wip_479_2.7
594, 617 dchenbecker, dpp, timperrett, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
Required a good deal of hacking around.

Tried updated test-squerylrecord, however the screen acted "funny" (showing results sometimes not others, no validation). I have no idea if my screen configuration is correct or not, so I'd like someone who has more experience with Screen to tell me if it works as expected (Harry? Tim P? David?)
David Pollak
Posted 1 year, 5 months ago (August 24th, 2010, 5:15 a.m.)
I think all the toForm methods need an explicit return type so the compiler doesn't infer the return type to Empty (that happened in the Mapper stuff).  Other than that, it looks like a really good change.
I think you have to be explicit about the return type here:
def toForm: Box[NodeSeq] = Empty

otherwise you won't be able to override the method.
David Pollak
Posted 1 year, 5 months ago (August 24th, 2010, 5:15 a.m.)
I think all the toForm methods need an explicit return type so the compiler doesn't infer the return type to Empty (that happened in the Mapper stuff).  Other than that, it looks like a really good change.
Ship it!
Tim Nelson
Posted 1 year, 5 months ago (August 24th, 2010, 7:51 a.m.)
I compiled your branch locally and ran all of the MongoDB tests and they all pass. I also updated my personal code to run with this branch and everything looks good.
Review request changed
Updated 1 year, 5 months ago (August 24th, 2010, 2 p.m.)
Made all toForm overrides/defs have a type signature.
Note that the test cases in lift-record did not really disappear, they're just in separate commits so when I diffed them this time I forgot to include the second commit
Ship it!
David Pollak
Posted 1 year, 5 months ago (August 24th, 2010, 4:09 p.m.)
Looks good.  Make it happen!