Review Board 1.5.4

[3/3] issue354 - record field initialization, redux

Updated 1 year, 5 months ago

Ross Mellgren Reviewers
rmm_wip_479_2.7
354 dchenbecker, dpp, timperrett, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
object initialization order is not reliable in the direction that made the change for issue354 work, so reverse that change and rely on MetaRecord.createRecord. The new record pattern is:

class Foo private () extends Record[Foo] {
  ...
}

object Foo extends Foo with MetaRecord
lift-record unit tests, lift-couchdb unit tests, plus compile of lift-mongodb tests
Ship it!
Posted 1 year, 5 months ago (August 24th, 2010, 5:22 a.m.)
Yeah... I guess we gotta make this change.  Frack.  It's still going to bite us when someone in the real world doesn't do the private () thing in their constructor.  Sigh.
Ship it!
Posted 1 year, 5 months ago (August 24th, 2010, 7:52 a.m.)
See [1/3] for comments.
Review request changed
Updated 1 year, 5 months ago (August 24th, 2010, 2:01 p.m.)
Change ripple from [1/3]