Review Board 1.5.4

MegaDump -- Issue 604, 605, 603, 598, 595, 592, 581, 582, 568, 583, 575, 594

Updated 1 year, 5 months ago

David Pollak Reviewers
dchenbecker, dpp, timperrett, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
A big pile of changes.  Sorry guys... I just didn't have time to break all these changes up into separate reviews.

https://liftweb.assembla.com/spaces/liftweb/tickets/604?batch=false&tickets_report_id=1&ticket_id=604&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/603?batch=&tickets_report_id=1&ticket_id=603&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/598?batch=&tickets_report_id=1&ticket_id=598&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/595?batch=&tickets_report_id=1&ticket_id=595&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/592?batch=&tickets_report_id=1&ticket_id=592&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/581?batch=&tickets_report_id=1&ticket_id=581&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/582?batch=&tickets_report_id=1&ticket_id=582&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/567?batch=&tickets_report_id=1&ticket_id=567&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/594?batch=&tickets_report_id=1&ticket_id=594&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/583?batch=&tickets_report_id=1&ticket_id=583&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/575?batch=&tickets_report_id=1&ticket_id=575&commit=Go+%C2%BB

https://liftweb.assembla.com/spaces/liftweb/tickets/575?batch=&tickets_report_id=1&ticket_id=575&commit=Go+%C2%BB

Misc testing
Ship it!
Posted 1 year, 6 months ago (July 30th, 2010, 8:10 a.m.)
Looks great. I have a few comments, but otherwise it looks ready to commit.
Is addition of two hashcodes really a safe way to compute a new hashcode?
This seems eerily similar to what we have in runQuery. Let's commit what you have here, and I can open a new (related) toicket and work on refactoring the common code out after 2.1-M1 is released.
Posted 1 year, 6 months ago (July 30th, 2010, 8:11 a.m.)

   

  
Sorry, meant to select all of runUpdate, not just this one line :P