Review Board 1.5.4

Issue 566 add base64EncodeURLSafe method to security helpers

Updated 1 year, 6 months ago

David Pollak Reviewers
dchenbecker, dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
dpp_issue_566

https://liftweb.assembla.com/spaces/liftweb/tickets/566-add-base64encodeurlsafe-to-securityhelpers

Added the method, upgraded to Codec 1.4 and fixed some issues with 1.4
Passes existing tests
Ship it!
Derek Chen-Becker
Posted 1 year, 6 months ago (July 29th, 2010, 10:17 a.m.)
Looks good to me. Were we seeing cases where the Base64 encoder was spitting out non 7-bit clean bytes?
  1. It's not the 7 bit issue, it's the length getting wrapped so you get CRs in the byte stream which means you can't put the base 64 encoded stuff in a URL parameter.