Review Board 1.5.4

Fix for http://github.com/dpp/liftweb/issues#issue/100

Updated 2 years, 3 months ago

Marius Danciu Reviewers
dchenbecker, dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive
The problem was the encodeUrl was not called when calculating the comet path.

The diff also contains a few things unrelated with this fix

1. Putting LiftSession's request-vars in a single place to make them more visible in the code
2. Added more JSExp-s for replacing an element with a NodeSeq - related with #56

Marius
I tested it having the cookies both turned off and on.
Review request changed
Updated 2 years, 3 months ago (October 15th, 2009, 9:06 a.m.)
  • 
    	  

    I tested it having the cookies both turned off and on.
Added a comment.

Any thoughts?
Ship it!
Posted 2 years, 3 months ago (October 16th, 2009, 11:26 a.m.)
Looks good to me.