Review Board 1.5.4

Issues: 577, 578, 579: Converge 2.7.x and 2.8.x codebase and other related ones

Updated 1 year, 7 months ago

Indrajit Raychaudhuri Reviewers
irc_converge_27, irc_converge_28
577, 578, 579 dchenbecker, dpp, timperrett, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
https://www.assembla.com/spaces/liftweb/tickets/577
https://www.assembla.com/spaces/liftweb/tickets/578
https://www.assembla.com/spaces/liftweb/tickets/579

Key points:
- Make the two 2.x branches less divergent
- Update a bunch of dependencies and plugins (h2database, specs, maven-jetty-plugin, maven-scala-plugin)
- Enable unified scaladoc generation
- A bunch of vscaladoc packageLinkDefs updates

NB: The existing patch is for the 2.8 branch. A similar one exists for 2.7 branch but RB doesn't allow multiple patch per request :(

Local full build.
Ship it!
Derek Chen-Becker
Posted 1 year, 7 months ago (July 8th, 2010, 1:06 p.m.)
Looks good. As a suggestion, we may want to centralize the various dependency and Maven plugin versions somewhere if possible, since it looks like you had to make a lot of duplicate changes on all of the poms (maven-scala-plugin version, for example).
  1. Hmmm. Wait a minute. What's up with the changes to JsonAST.scala, BindHelpers.scala, etc? 
  2. maven-scala-plugin versions are explicit in archetype resources (so that generated pom.xml works 'as is') and examples (so that they work even outside Lift's package hierarchy.
Generally this is the pattern I am trying to follow. Any opinion on this?

There is another reason why maven-scala-plugin configs get duplicated with the same pom.xml. To let scala:doc as well as scaladoc (as part of site) works identically. Maven is a huge PITA on this one.

JsonAST.scala: All firstOptions being replaced by headOption. Scala 2.7 had deprecated headOption in favor of firstOption but Scala 2.8 has deprecated firstOption in favor of headOption.

BindHelpers.scala: Little formatting and reordering of methods - that's all in 2.8 branch. In 2.7 branch case classes have been replaced by final class(es) and their helper objects.

  3. Cool. Looks good!