Review Board 1.5.4

Add detailed toString method to PaypalInfo

Updated 1 year, 6 months ago

Tim Perrett Reviewers
557 dpp, timperrett, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
In order to more effectivly debug setting up of IPN handlers; add a detailed toString method for the PaypalInfo struct so that users can see by dumping the object to logger exactly what was supplied on the wire by paypal.com

IPN simulator from developer.paypal.com (also using it in my Lift in Action book)
Ship it!
David Pollak
Posted 1 year, 7 months ago (June 20th, 2010, 3:49 p.m.)
Looks fine
  1. Okey doke - where exactly am i pushing this too... as master is out of bounds? We also need to clean up the branches on github, there are loads and loads of out of date ones on there. 
  2. In 2.x-2.7-devel and 2.x-2.8-devel once they are created after 2.0 release.

+1 on cleaning up the branches though.
  3. Can I merge this into master now?
  4. Since this is for 2.x series, feel free to merge these on 2.x-2.7_devel and 2.x-2.8_devel.

Open question: should these be pushed to master (3.0 series) as well?
  5. Push to the 2.x branches only.  Master is going to go through a lot of changes (e.g., sbt and fixing the package braces, etc.)

We have to start tracking changes that cannot be applied as patches because the files will have moved and the files will be radically changed.