Review Board 1.5.4

Issue 527 -- change EmptyBox from EmptyBox[+A] extends Box[A] to EmptyBox extends Box[Nothing]

Updated 1 year, 8 months ago

David Pollak Reviewers
dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
https://liftweb.assembla.com/spaces/liftweb/tickets/527?batch=&tickets_report_id=1&ticket_id=527&commit=Go+%C2%BB

dpp_issue_527

None of EmptyBox's subclasses (Empty and Failure) have a type other than Nothing, so make EmptyBox so it does not take a type parameter, but it is a subclass of Box[Nothing]

This makes pattern matching cleaner, but it's a breaking change for folks pattern matching against EmptyBox[_]
All existing tests pass.
Ship it!
Posted 1 year, 8 months ago (May 26th, 2010, 11:26 p.m.)
yup