Review Board 1.5.4

#478 Make the default docType configurable in LiftRules

Updated 1 year, 8 months ago

Marius Danciu Reviewers
478 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
Deprecating ResponseInfo but preserve backward compatibility.Moved docType to LiftRules
set doc type via ResponseInfo as well as LiftRules
Ship it!
Posted 1 year, 8 months ago (June 1st, 2010, 11:36 a.m.)
I'd rather see a FactoryMaker than a var, but it's cool.
Review request changed
Updated 1 year, 8 months ago (June 1st, 2010, 1:21 p.m.)
For consistency sake I totally agree. I aimed for a smooth transition but in the context of LiftRules it makes sense. Please see the updated diff. Did the same tests as before and worked fine.
Ship it!
Posted 1 year, 8 months ago (June 1st, 2010, 1:29 p.m.)
Excellent!