Review Board 1.5.4

Broaden S.notice et al so that one can configure JsCmd's

Updated 1 year, 8 months ago

Marius Danciu Reviewers
502 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
Added ability to generically specify JS effects on notices real estates.
yes
Ship it!
Posted 1 year, 8 months ago (May 15th, 2010, 4:45 a.m.)
Looks good. Would it make sense to make the fadeOut commands just default effects?
  1. I'd rather not to. The default should be no effects. autoFadeOut mechanism provides a high level API for fading out notices. This noticesEffects mechanism should be use for more advanced effects. 
  2. Ok, sounds very reasonable.
Ship it!
Posted 1 year, 8 months ago (May 17th, 2010, 12:30 p.m.)
Looks good