Review Board 1.5.4

Delegate all IE (browser) handling to XhtmlResponse to fix node handling

Updated 1 year, 1 month ago

Tim Perrett Reviewers
520 dpp, marius, jorge, rmellgren
None LiftWeb-archive 
Delegates all IE (browser) handling to XHTML response so that NodeResponse doesnt need to know about IE or whatever. Specifically, an API I have should return <test /> not <test></test>... AltXML was using the wrong overload because it was specialised for XHTML, not general XML rendering by which all nodes should be self terminated if there is no child content or CDATA 
smoke testing with the apps im working on.
David Pollak
Posted 1 year, 8 months ago (May 11th, 2010, 6:36 a.m.)
I am very, very, very, very wary of this change.  The balance for getting things right with IE currently works.  I would like to see a large cross-sectional test of production apps across IE6, IE7 and IE8 before accepting a change like this.
  1. Yeah I feel your concern David - TBH, I kinda expected you to say that considering how close we are to a 2.0 final. Tell you what, can I sit on this until post-2.0 and then re-evaluate it with an accompanying test application that covers all the known IE crazies when we have 2.0 out the door?
Marius Danciu
Posted 1 year, 8 months ago (May 11th, 2010, 11:47 a.m.)
The changes make A LOT of sense to me because AltXML.toXML from NodeResponse takes care of IE stuff BUT not all NodeResponses are Xhtml-s. A plain XML won't need it. Other XML representations would most likely want to write nodes with no children in the short form <xxx /> instead of <xxx></xxx>.

However if the consensus is for this to wait until after 2.0 or until it is fully tested I am of course in agreement with it.