Review Board 1.5.4

Mongo and Facebook fixes for #506, #507, #508

Updated 1 year, 9 months ago

Jorge Ortiz Reviewers
jorge_issue_506_507_508
506, 507, 508 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
Closes #506, #507, and #508. Mongo stuff: MongoDB is not thread-safe, duplicate introspect call causes NPE, add bulkDelete. Facebook stuff: calls to FB API should time out after 1 minute.

 

 




  

 











 

  




 

   Review request changed
   
Updated 1 year, 9 months ago (May 3rd, 2010, 4:12 p.m.)

 

 

  
    

   
  • 


changed from  to jorge_issue_506_507_508
    




   
    • 

   
  • 


    


   
    • 

  


 




  

 













 

  




 

 

  
Ship it!

  
David Pollak

  
Posted 1 year, 9 months ago (May 3rd, 2010, 4:15 p.m.)

 

 

   
All looks sane and reasonable

   

  

   
    
    
   


  




  
 




  

 
















 

  




 

 

  
Ship it!

  
Tim Perrett

  
Posted 1 year, 9 months ago (May 3rd, 2010, 4:39 p.m.)

 

 

   
Looks good :-) I've not built it, but I assume it works! Also, dont forget to merge with 280_port_refresh

   

  

   
    
    
   


  




  
 




  

 
















 

  




 

 

  
Ship it!

  
Tim Nelson

  
Posted 1 year, 9 months ago (May 3rd, 2010, 6:01 p.m.)

 

 

   
Looks good to me.

   

  

   
    
    
   


  




  
 




  

 


















 

  




 

 

  
  
Harry Heymann

  
Posted 1 year, 9 months ago (May 3rd, 2010, 7:37 p.m.)

 

 

   

   

  

   
    
    
   


  




   



    

     
     
    

    

     
Also need:

conn.setConnectTimeout(1.minute.millis.toInt)

Also 1 minute seems very long to me.  How about 10 seconds?  (perhaps this should even be a var on the obect?).

(comment also applies to like 167)