Review Board 1.5.4

Issue 499 -- create a mechanism to purge unwanted sessions

Updated 1 year, 9 months ago

David Pollak Reviewers
dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
https://liftweb.assembla.com/spaces/liftweb/tickets/499-cleaning-up-single-use-liftsessions

dpp_issue_499

capture a whole lot more information about sessions is captured.  Every 10 seconds a function is called and that function can shuffle through the information and purge sessions

 

 




  

 













 

  




 

 

  
Ship it!

  
Ross Mellgren

  
Posted 1 year, 9 months ago (April 29th, 2010, 2:17 p.m.)

 

 

   
Looks good to me although I'm not super familiar with SessionMaster

   

  

   
    
    
   


  




   



    

     
     
    

    

     
Maybe a doc comment explaining the arguments? E.g.

/**
 * List of functions to apply to the current active sessions periodically to clean out sessions faster.
 * Each function receives the map of sessions by session ID as well as a function to shut down the session.
 */


     

  

   
    
    
   


  



    

    

   


  
 




  

 
















 

  




 

 

  
Ship it!

  
Harry Heymann

  
Posted 1 year, 9 months ago (April 29th, 2010, 3:32 p.m.)

 

 

   
Just two comments.

   

  

   
    
    
   


  




   



    

     
     
    

    

     
delete this line instead of commenting out?

     

  

   
    
    
   


  



    

    

    

     
     
    

    

     
Should this code be turned into a sessionCheckFunction?  As the default?

     

  

   
    
    
   


  



    

    

   


  
 




  

 


















 

  




 

 

  
Ship it!

  
Marius Danciu

  
Posted 1 year, 9 months ago (April 29th, 2010, 11:33 p.m.)

 

 

   
Good stuff. I'm a little uncertain about the IP thing. How helpful is this if there are a bunch of clients behind the same NAT ?

   

  

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    The IP Address thing is valuable because search engines publish their IP address groups.  Purging based on that information will help FourSquare get rid of crawler sessions a lot faster than non-crawler session.
    
    
    
   
    2.