Review Board 1.5.4

Issue 461, 467, 482, 487, 495, 496, 464, 497, 477

Updated 1 year, 9 months ago

David Pollak Reviewers
dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
https://liftweb.assembla.com/spaces/liftweb/tickets/461?batch=&tickets_report_id=u7093&ticket_id=461&commit=Go+%C2%BB

Added JsonCommand extractor for helpful pattern matching with JSON commands sent to the server.  Added a test

https://liftweb.assembla.com/spaces/liftweb/tickets/467?batch=false&tickets_report_id=1&ticket_id=467&commit=Go+%C2%BB

Exceptions during view processing are handled the same way as exceptions during snippet processing rather than being silently swallowed.  Tested against code in the ticket.

https://liftweb.assembla.com/spaces/liftweb/tickets/482?batch=false&tickets_report_id=1&ticket_id=482&commit=Go+%C2%BB

all asJsExp methods have an explicit return type rather than a type-inferred return type.  The change was necessary to allow changing the kind of expressions returned by asJsExp in Mapper subclasses.

https://liftweb.assembla.com/spaces/liftweb/tickets/487?batch=false&tickets_report_id=1&ticket_id=487&commit=Go+%C2%BB

Changed from StatefulSnippet to DispatchSnippet in a number of S methods.  This allows for setting named DispatchSnippets.

https://liftweb.assembla.com/spaces/liftweb/tickets/495?batch=false&tickets_report_id=1&ticket_id=495&commit=Go+%C2%BB

Certain MapperRules were vals rather than vars.  This means that they could not be changed.  I changed quoteColumnName and quoteTableName from val to FactoryMaker

https://liftweb.assembla.com/spaces/liftweb/tickets/496?batch=false&tickets_report_id=1&ticket_id=496&commit=Go+%C2%BB

There were performance issues (repeated calls to createUpdate) and lack of subclassability of eventuallyUpdate (it was private so you couldn't change its behavior).  I changed the code and cleaned things up.

https://liftweb.assembla.com/spaces/liftweb/tickets/464?batch=false&tickets_report_id=1&ticket_id=464&commit=Go+%C2%BB

Cleaned up a problem with how URLs were parsed by Textile.  Added a test.

https://liftweb.assembla.com/spaces/liftweb/tickets/497?batch=false&tickets_report_id=1&ticket_id=497&commit=Go+%C2%BB

The column and table name re-name based on SQL reserved words can be disabled and the list of reserved words can be changed.

https://liftweb.assembla.com/spaces/liftweb/tickets/477?batch=false&tickets_report_id=1&ticket_id=477&commit=Go+%C2%BB

encodeAsJSON now returns a Box[JValue] so fields can exclude themselved.

All in GitHub on the dpp_stuffer branch
Tests described with each ticket
Ship it!
Posted 1 year, 9 months ago (April 28th, 2010, 12:31 a.m.)
Holly cow ! ... you've been busy.