Review Board 1.5.4

Issue 471 -- Overeager conversion to XML entities

Updated 1 year, 9 months ago

David Pollak Reviewers
dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
https://liftweb.assembla.com/spaces/liftweb/tickets/471-make-entity-resurection-feature-optional

dpp_issue_471

Up through 2.0-M3, the Scala XML parser converted entites to their Unicode character representation.  Ticket #274 requested that entities be converted from their unicode representation to an entity (e.g., —) on output.  This, it turns out, causes lots of problems if the entity is not referenced by XML.

For issue 471, I added a LiftRule that governs the entity resurrection and, by default, disables it.  This returns Lift to its previous behavior, but allows new behavior on a session, request, or thread basis.
New test added
Ship it!
Posted 1 year, 9 months ago (April 13th, 2010, 10:44 p.m.)
Looks good to me.
Ship it!
Posted 1 year, 9 months ago (April 13th, 2010, 11:03 p.m.)
Looks fine.