Review Board 1.5.4

Allow streaming a file directly using an OutputStream

Updated 1 year, 9 months ago

Marius Danciu Reviewers
372 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
Discussion here: http://groups.google.com/group/liftweb/browse_frm/thread/1bfc18d9410ee047

 

 




  

 















 

  




 

 

  
Ship it!

  
David Pollak

  
Posted 1 year, 9 months ago (April 13th, 2010, 9:16 a.m.)

 

 

   
Is there a way to make the length field a Box[Long] for the events that the length is not known?  If the answer is no, then ship it.  If the answer is yes, please update the code and then ship it.

Tnx

   

  

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Love the pragmatism. The answers is not quite since we need to set the Content-Length and without caches we can't really know how to compute Content-Length (... and Id rather avoid caching). However I can have size: Box[Long] the user can provide Empty but then it is user's responsibility to use HTTP chunking which is the appropriate way of dealing with HTTP payload when the overall size is not really known. 

Is that reasonable ?
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    It's reasonable
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    Actually can't really use Box due to API definitions ... :D but perhaps use a convention. If size is -1 we don't set the Content-Length at all ?
    
    
    
   
    4. 


   
  4. 
    
    
     
    
      
     
    
     
    I think it's more problem than it's worth.  If we get an actual feature request, we can change it... but for now... Ship it
    
    
    
   
    5.