JsCmds/JqJsCmds API normalization
Updated 1 year, 10 months ago
| Marius Danciu | Reviewers | ||
| 407 | dpp, timperrett, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday | ||
| None | LiftWeb-archive | ||
I tried to normalize the API and minimize the breaking changes. 1. I renamed JsMethod to JsMember and this will lead to breaking changes. The reason I did this is because JsMethod was used too loosely even in context like document.getElementById(id).value = ... where .value was expressed as a JsMethod. It doesn't feel right to me as while we're talking about a.b whether b is a function or an attribute it is a member of that "object". I tend to think that not many people are using explicitly JsMethod (just a hunch). However if you strongly feel that this is not right I can put JsMethod back but JsMember seems much more expressive to me. 2. I deprecated JQueryLeft and JQueryRight. For classes that mixed in JQueryRight I also added JsMember in the mixin. Ths the only reason for keeping JQueryRight around is backward compatibility. This should go away in a couple of releases IMHO. 3. JQueryLeft is also deprecated extending/mixing JsExp is enough. For classes that are mixing in JQueryLeft I kept it around solely for backward compatibility reasons. 4. I addded to JsExp >> method which is identical with ~> solely for backward compatibility reasons stating that this will go away soon. Of course that my impuls it so just remove JQueryLeft, JQueryRight and >> but no one is going to let me do this :( If by any chance you've noticed other things that should be normalized, please do let me know.
Review request changed
Updated 1 year, 11 months ago (March 8th, 2010, 5:08 a.m.)
-
- added Diff r2
replaced some more >> with ~>
Posted 1 year, 11 months ago (March 10th, 2010, 6:07 a.m.)
Is it worth putting @deprecated on def >> ?
Review request changed
Updated 1 year, 11 months ago (March 10th, 2010, 6:18 a.m.)
-
- added Diff r3
Done.
Posted 1 year, 10 months ago (March 12th, 2010, 11:25 a.m.)
Any feedback ?
