Review Board 1.5.4

Issue 233 -- support setObject without an explicit SQL type

Updated 1 year, 10 months ago

David Pollak Reviewers
dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
https://liftweb.assembla.com/spaces/liftweb/tickets/233-feature-request-metamapper-setobject-overload-without-sql-type

dpp_issue_233

Added a dbIgnoreSQLType_? flag on MappedField so that the SQL type will not be used in setObject for that field.
None
Jeppe Madsen
Posted 1 year, 11 months ago (February 25th, 2010, 11:38 p.m.)
It seems the st.setObject stuff could be extracted into a method. Otherwise easy to forget to check for the flag
  1. If we put the method on field, it would get really ugly.  Where else would you suggest putting it?
  2. Ouch, just noticed this draft reply been sitting here for 6 days, 9 hours. Sorry!

-----
Seems like most of the setObject calls happens in metamapper, so it could be a package private method here. But this may be too much trouble for this...it's just that special cases like this are pretty easy to forget, or get wrong (for me at least :-) when adding new code. Having at centralized helps I think