Review Board 1.5.4

LiftRules.jQueryVersion should not be there.

Updated 1 year, 11 months ago

Marius Danciu Reviewers
363 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive 
LiftRules API should not be coupled with underlying JavaScript framework. JsArtifacts can now decide the path rewriting rules. 
yes
Ship it!
Jeppe Madsen
Posted 1 year, 11 months ago (February 23rd, 2010, 11:58 p.m.)
What's the policy about JQuery versions? Always latest minor rev? In that case 1.4.2 is out, so either 

1) we should replace 141 with 142
2) or add 142 at some point....

If 1) we should do it now since people will have to change their code anyway
  1. Based on this http://blog.jquery.com/ I say #1 to just use jquery 1.4.2.
  2. I think we should only upgrade to a newer revision for stable external libraries like jQuery if there are changes and fixes people need (usually this means only the latest major revisions). However, given the significant performances improvements in 1.4.2 it sounds like we should use it. Just my 2 cents.
  3. We're not essentially upgrading to 142 since the default JQuery version is still 1.3.2 .. we just add support and this point 1.4.2 looks like a better choice than 1.4.1.

I'll make the adjustments and post the diffs. 
  4. Quite so.

Instead of having JQuery132Artifacts and JQuery141Artifacts, how about having just JQuery13Artifacts and JQuery14Artifacts? This is loosely along the lines of standard -java14, -java15 suffix.
The rationale is with the assumption that an application would more likely switch between jQuery 1.3 or jQuery 1.4 and not necessarily between jQuery 1.4.1 or jQuery 1.4.2 etc.
  5. To clarify, jQuery does not introduce breaking changes in micro version. So we should attempt to keep rolling up versions for a micro release from time to time (both for 1.3 series as well as 1.4 series) unless something breaks terribly in a newer micro release.

The user is free to choose either JQuery13Artifacts (default) or JQuery14Artifacts without worrying about the code changes to pick up the newer version that a particular version of Lift packages.
  6. Yes I understood your rationale :) ... and I tend to agree.
Review request changed
Updated 1 year, 11 months ago (February 24th, 2010, 8:29 a.m.)
Update diff .. please review.
Ship it!
Jeppe Madsen
Posted 1 year, 11 months ago (February 24th, 2010, 10:19 a.m.)
Nice!