Review Board 1.5.4

Solve CSS/JS unwanted caching

Updated 1 year, 11 months ago

Marius Danciu Reviewers
346 dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb, dlouwers, mstarzyk, rmellgren, jhoffman, probinett, jmadsen, mhartmann, jstrachan, jgoday
None LiftWeb-archive
Allow the ability for user's function to add id-s for resource URI's in order to have proper resource refresh and browse cache optimization.
yes
Ship it!
Posted 1 year, 11 months ago (February 22nd, 2010, 9:50 a.m.)
simple!
Posted 1 year, 11 months ago (February 22nd, 2010, 9:52 a.m.)
Actually I thought of a case just after putting my review up. The default attachResourceId will generate an incorrect URI if the href/src attribute already includes a query string. It should probably test the URI passed in for a ? before adding a ? and adding a & instead
  1. Yes I thought of that ... but typically link/script tags do not have query string params. But I agree we should be safer ..
Review request changed
Updated 1 year, 11 months ago (February 22nd, 2010, 10:29 a.m.)
Updated per Ross' comments
Ship it!
Posted 1 year, 11 months ago (February 22nd, 2010, 10:35 a.m.)
looks good
Ship it!
Posted 1 year, 11 months ago (February 22nd, 2010, 11:09 a.m.)
nice!
Ship it!
Posted 1 year, 11 months ago (February 23rd, 2010, 4:31 a.m.)
Nice stuff.