Review Board 1.5.4

lift-imaging added module

Updated 2 years ago

Tim Perrett Reviewers
wip_tim_285
dpp, marius, naftoli, kris, indrajit, alexb, rmellgren
None LiftWeb-archive
Added Ross' imaging code to lift in a module called "lift-imaging"
Just compile tested it... trusting Ross' judgement here ;-)
Ship it!
Posted 2 years ago (January 18th, 2010, 2:11 p.m.)
uh-oh, I'm not sure if I trust Ross' judgement, though we have QA'ed it a bunch of times and it apparently works.
the only nitpick I have is that the indentation is inconsistent. I sent it originally as 4-space (since that's what I prefer), but part of this has been modified to have 2-space.
probably should be one or the other (4-space? ;-) )
Ship it!
Posted 2 years ago (January 19th, 2010, 3:08 a.m.)
Haven't tested locally. But looks fine.

Few points:
1. I like 4 spaces for tabs too, but let's prefer consistency (2 spaces)
2. Consider adding some test scripts in due course :)
  1. Agreed - i made some changes and here is the latest diff file... Shall I adjust to the new package style before commiting it? 
    
  2. Just check-in 'as is'. I'll do mass update on the package.
  3. Awesome - i'll do the merge now
Review request changed
Updated 2 years ago (January 19th, 2010, 6:46 a.m.)
Fixed the spacing issue - just waiting on weather or not i should make it 2.8 packaging style?