uh-oh, I'm not sure if I trust Ross' judgement, though we have QA'ed it a bunch of times and it apparently works. the only nitpick I have is that the indentation is inconsistent. I sent it originally as 4-space (since that's what I prefer), but part of this has been modified to have 2-space. probably should be one or the other (4-space? ;-) )
Haven't tested locally. But looks fine. Few points: 1. I like 4 spaces for tabs too, but let's prefer consistency (2 spaces) 2. Consider adding some test scripts in due course :)
Review request changed
Updated 2 years ago (January 19th, 2010, 6:46 a.m.)
-
- added Diff r2
Fixed the spacing issue - just waiting on weather or not i should make it 2.8 packaging style?
