Review Board 1.5.4

Adding DataBinding pattern stuff

Updated 1 year, 11 months ago

Kris Nuttycombe Reviewers
kjn-bindings-wip
212 dchenbecker, dpp, marius, charles, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive 
See http://logji.blogspot.com/2009/09/composable-bindings-in-lift.html for a description of how this is to be used. Finally got around to extricating this from the gunk I had surrounding it for inclusion.
In production use.
Ship it!
David Pollak
Posted 2 years, 1 month ago (December 9th, 2009, 1:01 p.m.)
Looks good, but I'd prefer to see it in the util package... does it need to be in http.xml?
  1. My initial thought had been to put it in util, but as it uses TemplateFinder it sort of needs to go in webkit. I'd welcome any other suggestions on which package to put it in. Or were you just meaning put it in net.liftweb.util, but in the webkit subproject? That seems reasonable.
  2. Sorry... didn't see that dependency... how about just putting it in http rather than http.xml?
  3. Sure.
Review request changed
Updated 2 years, 1 month ago (December 9th, 2009, 9:03 p.m.)
Moved to http package.
Indrajit Raychaudhuri
Posted 2 years, 1 month ago (December 10th, 2009, 12:20 a.m.)
Cool!

A few points:
1. Some scaladoc would be very good
2. A test case would be awesome :) More than unit testing functionality, serves as an use case like you have in the blog.
3. Indentation & Tabs: Lift follows 2 space for tabs
  1. Good suggestions - I'll add a test & scaladoc.
Ship it!
Marius Danciu
Posted 2 years, 1 month ago (December 18th, 2009, 1:58 a.m.)
cool
Ship it!
Tim Perrett
Posted 2 years, 1 month ago (December 24th, 2009, 2:50 p.m.)
Can I suggest that you put a link to your great blog article in the comments? That would perhaps add some context.
Review request changed
Updated 1 year, 11 months ago (February 28th, 2010, 3:19 p.m.)
Added documentation & unit tests to demonstrate functionality.