Review Board 1.5.4

Fix for issue 216 - Allow better flexibility in specifying the suffix splitting algorithm.

Updated 2 years, 1 month ago

Marius Danciu Reviewers
216 dchenbecker, dpp, marius, charles, heiko, joni, atsuhiko, jorge, naftoli, kris, indrajit, alexb
None LiftWeb-archive 
Allow users to specify their own suffix splitting rules. Current Lift behaviour in splitting is considered the default splitting algorithm. I also moved the suffixes list in the HttpHelpers and the LiftRules variable just reflects that. It just seems cleaner to me ... but speak up if you don't agree.


Br's,
Marius

 

 




  

 













 

  




 

 

  
  
David Pollak

  
Posted 2 years, 2 months ago (December 5th, 2009, 12:07 p.m.)

 

 

   
I'd prefer not to add mutable stuff to things in the util package.  Can we keep the white list in LiftRules?

   

  

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    knownSuffixes from HTTPUtils is a val not a var. The Set from LiftRules is mutable thought as it was before. Sure if you really want to I can leave it in LiftRules but IMHO this ugly-fies the LiftRules code.
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Sorry... I mis-read your code.  I agree that this is the correct approach.  Sorry... can you revert your changes and put the val back in HTTPUtils and reference from LiftRules.

Once you do that, please ship it.
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    OK I'll do that.
    
    
    
   
    4. 

   


  




  
 




  

 














 

  




 

   Review request changed
   
Updated 2 years, 2 months ago (December 6th, 2009, 10:03 a.m.)

 

 

  

  
  
Ok .. I left the suffixes in LiftRules but I still have seconds thoughts about this list :)

Br's,
Marius


 




  

 











 

  




 

   Review request changed
   
Updated 2 years, 1 month ago (December 7th, 2009, 9:13 a.m.)

 

 

  

  
  
Putting the list of suffixes back in helpers ...